Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/github: better handle blank scopes. #6135

Merged
merged 1 commit into from
May 15, 2019

Conversation

MikeMcQuaid
Copy link
Member

If both provided and required scopes are blank then we cannot display a good error message so don't try.

Fixes #6134.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

If both provided and required scopes are blank then we cannot display a
good error message so don't try.

Fixes #6134.
@MikeMcQuaid MikeMcQuaid merged commit 3dc3ab9 into Homebrew:master May 15, 2019
@MikeMcQuaid MikeMcQuaid deleted the github-handle-blank-scopes branch May 15, 2019 14:21
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in api_credentials_error_message
1 participant